Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical
From: Dmitry Osipenko
Date: Mon Jan 15 2018 - 05:56:31 EST
On 10.01.2018 16:59, Dmitry Osipenko wrote:
> Machine dies if HCLK, SCLK or EMC is disabled. Hence mark these clocks
> as critical.
>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> Acked-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
> ---
>
> Change log:
> v2: Fixed accidentally missed marking EMC as critical on Tegra30 and
> Tegra124. Switched to a use of common EMC gate definition on Tegra20
> and Tegra30.
>
> v3: Dropped marking PLL_P outputs as critical, because seems they are
> not so critical. Although, I still haven't got a definitive answer
> about what exact HW functions are affected by the fixed-clocks.
> Anyway it should be cleaner to correct the actual drivers.
Stephen / Michael, would it be possible to schedule these patches for 4.16? My
T20 and T30 devices aren't working without the 'critical clocks' patch. Things
happen to work with the opensource u-boot, but not with the proprietary
bootloader. It's probably not a big deal that out-of-tree devices are broken,
although would be nice to have one problem less.