Re: [PATCH] Revert "module: Add retpoline tag to VERMAGIC"

From: Andi Kleen
Date: Wed Jan 24 2018 - 10:44:18 EST


On Wed, Jan 24, 2018 at 03:28:17PM +0100, Greg Kroah-Hartman wrote:
> This reverts commit 6cfb521ac0d5b97470883ff9b7facae264b7ab12.
>
> Turns out distros do not want to make retpoline as part of their "ABI",
> so this patch should not have been merged. Sorry Andi, this was my
> fault, I suggested it when your original patch was the "correct" way of
> doing this instead.

It's ok for me to revert, but if it's reverted should consider
the warning only patch version instead.

https://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git/commit/?h=spec/retpoline-module-2&id=b40b7c1dbffaa636906b774ef5519882060e1aa0

I had posted that earlier, but reviewers in the end preferred
the simple modversions variant.

I think we should have something at least for 4.15 to catch mistakes.

-Andi