Re: [PATCH] x86: e820: Implement a range manipulation operator

[Andy Shevchenko]

On Fri, Feb 2, 2018 at 1:13 AM, Jan H. SchÃnherr <jschoenh@xxxxxxxxx> wrote:

> +                       [KNL,ACPI] Convert memory within the specified region
> +                       from <oldtype> to <newtype>. If "-<oldtype>" is left
> +                       out, the whole region will be marked as <newtype>,
> +                       even if previously unavailable. If "+<newtype>" is left
> +                       out, matching memory will be removed. Types are
> +                       specified as e820 types, eg, 1==RAM, 2==reserved,
> +                       3==ACPI, 12==PRAM.

s/==/ = /g


> +       } else if (*p == '%') {
> +               enum e820_type from = 0, to = 0;
> +
> +               start_at = memparse(p + 1, &p);
> +               if (*p == '-')
> +                       from = simple_strtoull(p + 1, &p, 0);
> +               if (*p == '+')
> +                       to = simple_strtoull(p + 1, &p, 0);
> +               if (*p != 0)

if (*p)

or

if (*p != '\0')

?

> +                       return -EINVAL;
> +               if (from && to)
> +                       e820__range_update(start_at, mem_size, from, to);
> +               else if (to)
> +                       e820__range_add(start_at, mem_size, to);
> +               else if (from)
> +                       e820__range_remove(start_at, mem_size, from, 1);
> +               else
> +                       e820__range_remove(start_at, mem_size, 0, 0);

-- 
With Best Regards,
Andy Shevchenko