Re: [PATCH] x86: e820: Implement a range manipulation operator

[Jan H. SchÃnherr]

On 02/02/2018 09:50 PM, Andy Shevchenko wrote:
> On Fri, Feb 2, 2018 at 1:13 AM, Jan H. SchÃnherr <jschoenh@xxxxxxxxx> wrote:
> 
>> +                       [KNL,ACPI] Convert memory within the specified region
>> +                       from <oldtype> to <newtype>. If "-<oldtype>" is left
>> +                       out, the whole region will be marked as <newtype>,
>> +                       even if previously unavailable. If "+<newtype>" is left
>> +                       out, matching memory will be removed. Types are
>> +                       specified as e820 types, eg, 1==RAM, 2==reserved,
>> +                       3==ACPI, 12==PRAM.
> 
> s/==/ = /g

Sure. I've also properly abbreviated that "e.g.".

>> +       } else if (*p == '%') {
>> +               enum e820_type from = 0, to = 0;
>> +
>> +               start_at = memparse(p + 1, &p);
>> +               if (*p == '-')
>> +                       from = simple_strtoull(p + 1, &p, 0);
>> +               if (*p == '+')
>> +                       to = simple_strtoull(p + 1, &p, 0);
>> +               if (*p != 0)
> 
> if (*p)
> 
> or
> 
> if (*p != '\0')
> 
> ?

Something similar to the latter is used in the function already. The latter it is.

Regards
Jan