Re: [PATCH 12/15] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c2 board file

[Sricharan R]

Hi Abhishek,

<snip ..>

>> +// SPDX-License-Identifier: GPL-2.0
>> +// Copyright (c) 2017, The Linux Foundation. All rights reserved.
>> +
>> +#include "qcom-ipq4019-ap.dk07.1.dtsi"
>> +
>> +/ {
>> +ÂÂÂ model = "Qualcomm Technologies, Inc. IPQ40xx/AP-DK07.1-C2";
> 
> Âs/IPQ40xx/IPQ4019
> 
 ok

>> +
>> +ÂÂÂ soc {
>> +ÂÂÂÂÂÂÂ pcie0: pci@40000000 {
>> +ÂÂÂÂÂÂÂÂÂÂÂ status = "disabled";
>> +ÂÂÂÂÂÂÂ };
> 
> ÂWe can disable in base dtsi itself.
> 

 hmm, as mentioned in the previous patch, feels better to enable
 it only in the board file specifically and not to touch this here
 and the common dtsi.

>> +
>> +ÂÂÂÂÂÂÂ pinctrl@1000000 {
>> +ÂÂÂÂÂÂÂÂÂÂÂ serial_1_pins: serial1_pinmux {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ mux {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins = "gpio8", "gpio9";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ function = "blsp_uart1";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ bias-disable;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂÂÂÂÂ spi_0_pins: spi_0_pinmux {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ mux {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins = "gpio13", "gpio14",
>> "gpio15";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ function = "blsp_spi0";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ bias-disable;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ cs1 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins = "gpio12";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ function = "gpio";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ host_int1 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins = "gpio10";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ function = "gpio";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ input;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ cs2 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins = "gpio45";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ function = "gpio";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ host_int2 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins = "gpio61";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ function = "gpio";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ input;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ rst {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins = "gpio36";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ function = "gpio";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ output-high;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
> 
> ÂNormally spi pins should contains spi protocol related pins
> Âcould you please explain what is the role of host_pin and rst
> Âpins and which driver will use these.
> 

 hmm, the additional pins were required for zigbee connected as the
 spidev device. So the right probably is to have the additional
 pins required for the device populated under the spi's child node.
 
>> +ÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂ serial@78b0000 {
>> +ÂÂÂÂÂÂÂÂÂÂÂ pinctrl-0 = <&serial_1_pins>;
>> +ÂÂÂÂÂÂÂÂÂÂÂ pinctrl-names = "default";
>> +ÂÂÂÂÂÂÂÂÂÂÂ status = "ok";
>> +ÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂ spi_0: spi@78b5000 { /* BLSP1 QUP1 */
>> +ÂÂÂÂÂÂÂÂÂÂÂ pinctrl-0 = <&spi_0_pins>;
>> +ÂÂÂÂÂÂÂÂÂÂÂ pinctrl-names = "default";
>> +ÂÂÂÂÂÂÂÂÂÂÂ status = "ok";
> 
> ÂFrom pinmux, it looks like multiple gpio based cs are being
> Âused so do we need to specify cs-gpios like dk01-c2.
> 

 ok, let me check.

Regards,
 Sricharan


-- 
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation