Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error
From: Marek Vasut
Date: Thu Feb 08 2018 - 16:53:09 EST
On 02/08/2018 10:33 PM, Marc Kleine-Budde wrote:
> On 02/08/2018 08:22 PM, Marek Vasut wrote:
>> On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote:
>>> On 02/08/2018 07:47 AM, Heiko Schocher wrote:
>>>> the driver reads in the ISR first the IRQpending register,
>>>> and clears after that in a write *all* bits in it.
>>>>
>>>> It could happen that the isr register raise bits between
>>>> this 2 register accesses, which leads in lost bits ...
>>>>
>>>> In case it clears "TX message sent successfully", the driver
>>>> never sends any Tx data, and buffers to userspace run over.
>>>>
>>>> Fixed this:
>>>> clear only the bits in the IRQpending register, the
>>>> driver had read.
>>>>
>>>> Signed-off-by: Heiko Schocher <hs@xxxxxxx>
>>>> Reviewed-by: Marek Vasut <marex@xxxxxxx>
>>>
>>> Applied both to linux-can.
>>
>> Can you also apply them to stable, so they get into 4.9.x etc ?
>
> I've already added stable on Cc, so they will be picked up by the stable
> maintainers.
Thanks!
--
Best regards,
Marek Vasut