Re: [PATCH] printk: move dump stack related code to lib/dump_stack.c

From: Sergey Senozhatsky
Date: Fri Feb 09 2018 - 03:42:50 EST


On (02/09/18 16:27), Dave Young wrote:
> > Seems that those functions are still defined in printk header.
> > Did you test !CONFIG_PRINTK build?

Apparently dump_stack(void) is also in printk.h

extern asmlinkage void dump_stack(void) __cold;

so it's "OK" to keep those functions in printk.h, I guess. I thought
that dump_stack() had its own header file...

> !CONFIG_PRINTK will use the dummy functions in printk.h, I did not test
> the build, doing it now to double confirm..

Not sure. Please test.

-ss