Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords

[Johannes Thumshirn]

On Tue, 2018-02-13 at 13:49 +0100, Matias BjÃrling wrote:
> +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> +			ÂÂÂÂu8 log_page, void *log,
> +			ÂÂÂÂsize_t size, size_t offset)
> +{
> +	struct nvme_command c = { };
> +	unsigned long dwlen = (size / 4) - 1;

Consulting my long gone maths knowledge suggests the parantheses aren't
really needed here.

-- 
Johannes Thumshirn                     ÂStorage
jthu
mshirn@xxxxxxx                Â+49 911 74053 689
SUSE
LINUX GmbH, Maxfeldstr. 5, 90409 NÃrnberg
GF: Felix ImendÃrffer, Jane
Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)
Key fingerprint = EC38
9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850