Re: [PATCH v2 0/3] power: supply: Fix AXP288 fallback when not needed

[Hans de Goede]

Hi,

On 16-02-18 09:51, Rafael J. Wysocki wrote:
> On Fri, Feb 16, 2018 at 9:41 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > Hi,
> >
> > On 16-02-18 09:26, Carlo Caione wrote:
> > > From: Carlo Caione <carlo@xxxxxxxxxxxx>
> > >
> > > With commits af3ec837 and dccfae6d a blacklist was introduced to avoid
> > > using the ACPI drivers for AC and battery when a native PMIC driver was
> > > already present. While this is in general a good idea (because of broken
> > > DSDT or proprietary and undocumented ACPI opregions for the ACPI
> > > AC/battery devices) we have come across at least one CherryTrail laptop
> > > (ECS EF20EA) shipping the AXP288 together with a separate FG controller
> > > (a MAX17047) instead of the one embedded in the AXP288.
> >
> >
> > Thank you for the new version. This looks good and surprisingly
> > clean / small given amounts of warts surrounding this all.
> >
> > The entire series is:
> >
> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> Well, to be honest, I very much prefer it when changes are made to one
> driver at a time.

I understand completely, Carlo can you do a v4 with the changes
Rafael requested please? Feel free to keep my Reviewed-by for the v4.

Regards,

Hans