Re: [PATCH v5 0/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

From: Ingo Molnar
Date: Fri Feb 16 2018 - 04:38:46 EST



* Baoquan He <bhe@xxxxxxxxxx> wrote:

> This is v5 post. Newly added patch 0002 includes the change
> related to KEXEC_JUMP path. Patch 0003 only includes the
> regression fix.
>
> A regression bug was introduced in below commit.
> commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC")
>
> It caused the action to fail that we try to restore boot irq mode
> in reboot and kexec/kdump. Details can be seen in patch 0003.
>
> Warning can always be seen during kdump kernel boot on qemu/kvm
> platform. Our customer even saw casual kdump kernel hang once in
> ~30 attempts during stress testing of kdump on KVM machine.
>
> v4->v5:
> Take out the change related to KEXEC_JUMP to a new patch 0002
> according to Eric's suggestion.
> Patch 0003 in this series only includes the regression fix.
>
> v3->v4:
> Eric pointed out that in patch 0002 the change related to
> KEXEC_JUMP is not right.
> Correct it.
>
> Add Fixes tag and Cc to stable.

Eric, are these patches looking good to you now?

Thanks,

Ingo