Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

[Mark Brown]

On Wed, Feb 14, 2018 at 11:07:39PM +0100, Sebastian Reichel wrote:

> +config SND_SOC_CPCAP
> +	tristate "Motorola CPCAP codec"
> +	depends on MFD_CPCAP
> +	default MFD_CPCAP
> +

We don't have default lines like this for other MFDs...

> +	SOC_ENUM("Hifi Left Phase Playback Switch",
> +		cpcap_hifi_l_phase_inv_enum),
> +	SOC_ENUM("Ext Left Phase Playback Switch",
> +		cpcap_ext_l_phase_inv_enum),

If this is a Switch control it should be a simple on/off binary control.
If it's an enumeration it shouldn't have Switch at the end of the name
since that's a keyword interpreted by userspace.  Either option seems
fine in this case, if it's a switch it should be "Foo Invert Switch" or
similar.

Attachment: signature.asc
Description: PGP signature