Re: [PATCH] HID: uhid: use strlcpy() instead of strncpy()

From: Jiri Kosina
Date: Fri Feb 16 2018 - 07:37:22 EST


On Tue, 9 Jan 2018, Xiongfeng Wang wrote:

> From: Xiongfeng Wang <xiongfeng.wang@xxxxxxxxxx>
>
> gcc-8 reports
>
> drivers/hid/uhid.c: In function 'uhid_dev_create2':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may
> be truncated copying 127 bytes from a string of length 127
> [-Wstringop-truncation]
>
> The compiler require that the input param 'len' of strncpy() should be
> greater than the length of the src string, so that '\0' is copied as
> well. We can just use strlcpy() to avoid this warning.

Applied to for-4.17/upstream.

--
Jiri Kosina
SUSE Labs