Re: [v4 5/6] mm/memory_hotplug: don't read nid from struct page during hotplug

From: Pavel Tatashin
Date: Fri Feb 16 2018 - 08:11:21 EST


> The namespace of all these memory range handling functions is horribly random,
> and I think now it got worse: we add an assumption that register_new_memory() is
> implicitly called as part of hotplugged memory (where things are pre-cleared) -
> but nothing in its naming suggests so.
>
> How about renaming it to hotplug_memory_register() or so?

Sure, I will rename it.

>
> With that change you can add:
>
> Reviewed-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thank you,
Pavel