Re: [PATCH-next] sched/headers: Clean up <linux/sched.h>
From: Christopher Díaz Riveros
Date: Fri Feb 16 2018 - 08:25:31 EST
El vie, 16-02-2018 a las 10:44 +0100, Juri Lelli escribiÃ:
> On 15/02/18 17:52, Peter Zijlstra wrote:
> > On Thu, Feb 15, 2018 at 10:43:18AM -0500, Christopher Diaz Riveros
> > wrote:
>
> [...]
>
> > > @@ -437,20 +437,28 @@ struct sched_dl_entity {
> > > * during sched_setattr(), they will remain the same
> > > until
> > > * the next sched_setattr().
> > > */
> > > - u64 dl_runtime; /*
> > > Maximum runtime for each instance */
> > > - u64 dl_deadline; /
> > > * Relative deadline of each instance */
> > > - u64 dl_period; /*
> > > Separation of two instances (period) */
> > > - u64 dl_bw;
> > > /* dl_runtime / dl_period */
> > > - u64 dl_density; /*
> > > dl_runtime / dl_deadline */
> > > + /* Maximum runtime for each instance */
> > > + u64 dl_runtime;
> > > + /* Relative deadline of each instance */
> > > + u64 dl_deadline;
> > > + /* Separation of two instances (period) */
> > > + u64 dl_period;
> > > + /* dl_runtime / dl_period */
> > > + u64 dl_bw;
> > > + /* dl_runtime / dl_deadline */
> > > + u64 dl_density;
> >
> > That's a whole lot less readable :/
>
> Yep. :(
Thank you all for the feedback, I'll consider this patch as NACK. Sorry
for wasting time in a low quality patch. I'll prepare a better one
next time :)
Regards,
--
Christopher DÃaz Riveros
Gentoo Linux Developer
GPG Fingerprint: E517 5ECB 8152 98E4 FEBC 2BAA 4DBB D10F 0FDD 2547