Re: [PATCH 7/9] KVM/VMX: Emulate MSR_IA32_ARCH_CAPABILITIES

From: David Woodhouse
Date: Fri Feb 16 2018 - 11:33:51 EST




On Fri, 2018-02-16 at 08:29 -0800, Jim Mattson wrote:
> On Fri, Feb 16, 2018 at 6:18 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> > Uhm, taking contents from the hardware is wrong (guess why---live
> > migration). I'll send a revert of those two lines.
>
> Hardware seems like a reasonable place to get the default value (cf.
> the VMX capability MSRs). Should these two lines just be moved to
> vmx_create_cpu?

They're already in vmx_create_cpu(). (Well, in vmx_cpu_setup() which is
a static function called only once, from vmx_create_cpu().)

Attachment: smime.p7s
Description: S/MIME cryptographic signature