Re: [PATCH 1/3] jump_label: Warn on failed jump_label patch

From: Steven Rostedt
Date: Fri Feb 16 2018 - 12:32:07 EST


On Thu, 15 Feb 2018 16:35:58 -0600
Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:


> > Interesting idea. The static key's entries (i.e. tracepoint sites) are
> > in a static array. Maybe we could rewrite the affected arrays when init
> > memory is freed. I'm not sure whether that would be overkill though. I
> > can tinker with it and see how it compares to the current solution.
>
> It turns out that something like this is already done for module init
> code. It doesn't *remove* the entry, but it does disable it by setting
> entry->code to zero. I'll just do the same thing right before initmem
> is freed.

Yes, I was actually going to mention to do it like the module code does.

Thanks!

-- Steve