Re: [PATCH v5 0/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump

From: Baoquan He
Date: Sat Feb 17 2018 - 06:28:42 EST


On 02/17/18 at 11:46am, Ingo Molnar wrote:
>
> * Baoquan He <bhe@xxxxxxxxxx> wrote:
>
> > Thanks for checking this!
> >
> > I got warning message from kbuild test robot on previous v3 and v4. I
> > guess this v5 post also has the issue since the code is the same, just
> > patch format is changed.
> >
> > Will report status after investigation.
>
> Well, your patches didn't build when CONFIG_IO_APIC is disabled - I have fixed
> this by the patch below.
>
> Thanks,
>
> Ingo
>
> ---
> arch/x86/include/asm/io_apic.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/io_apic.h b/arch/x86/include/asm/io_apic.h
> index 06fec4426458..fd20a2334885 100644
> --- a/arch/x86/include/asm/io_apic.h
> +++ b/arch/x86/include/asm/io_apic.h
> @@ -233,6 +233,7 @@ static inline void io_apic_init_mappings(void) { }
>
> static inline void setup_IO_APIC(void) { }
> static inline void enable_IO_APIC(void) { }
> +static inline void restore_boot_irq_mode(void) { }

Ah, yes, thanks. Ack this patch.

Acked-by: Baoquan He <bhe@xxxxxxxxxx>