Re: [PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start()

[Andy Shevchenko]

On Sun, Feb 18, 2018 at 3:22 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> On Fri, Feb 16, 2018 at 11:39:13AM +0200, Andy Shevchenko wrote:
>> On Thu, 2018-02-15 at 22:22 +0100, SF Markus Elfring wrote:
>> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> > Date: Thu, 15 Feb 2018 22:15:25 +0100
>> >
>> > Omit an extra message for a memory allocation failure in this
>> > function.
>> >
>> > This issue was detected by using the Coccinelle software.
>>
>> Tejun, it's up to you. In case you are fine with the change,
>
> Yeah, these are marginal at best and one may be able to argue that
> emitting a message with device identifier is still useful but these
> allocations are order-zero and can't fail to begin with, so...

IIRC device core prints a warn with error code and device name if
->probe() fails.

-- 
With Best Regards,
Andy Shevchenko