Re: [PATCH] cpufreq: s3c24xx: Delete an error message for a failed memory allocation in two functions
From: Viresh Kumar
Date: Sun Feb 18 2018 - 22:45:03 EST
On 15-02-18, 17:40, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 15 Feb 2018 17:28:40 +0100
>
> Omit an extra message for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/cpufreq/s3c24xx-cpufreq.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/cpufreq/s3c24xx-cpufreq.c b/drivers/cpufreq/s3c24xx-cpufreq.c
> index 7b596fa38ad2..024afd0b9458 100644
> --- a/drivers/cpufreq/s3c24xx-cpufreq.c
> +++ b/drivers/cpufreq/s3c24xx-cpufreq.c
> @@ -473,10 +473,8 @@ int __init s3c_cpufreq_setboard(struct s3c_cpufreq_board *board)
> * initdata. */
>
> ours = kzalloc(sizeof(*ours), GFP_KERNEL);
> - if (ours == NULL) {
> - pr_err("%s: no memory\n", __func__);
> + if (!ours)
> return -ENOMEM;
> - }
>
> *ours = *board;
> cpu_cur.board = ours;
> @@ -562,10 +560,8 @@ static int s3c_cpufreq_build_freq(void)
> size++;
>
> ftab = kzalloc(sizeof(*ftab) * size, GFP_KERNEL);
> - if (!ftab) {
> - pr_err("%s: no memory for tables\n", __func__);
> + if (!ftab)
> return -ENOMEM;
> - }
>
> ftab_size = size;
>
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
viresh