Re: [PATCH v2 0/6] wl1251: Fix MAC address for Nokia N900

From: Kalle Valo
Date: Mon Feb 19 2018 - 03:28:04 EST


Pali RohÃr <pali.rohar@xxxxxxxxx> writes:

> On Friday 05 January 2018 02:45:10 Luis R. Rodriguez wrote:
>> On Tue, Jan 02, 2018 at 08:23:45PM +0100, Pali RohÃr wrote:
>> > On Friday 10 November 2017 00:38:22 Pali RohÃr wrote:
>> > > This patch series fix processing MAC address for wl1251 chip found in Nokia N900.
>> > >
>> > > Changes since v1:
>> > > * Added Acked-by for Pavel Machek
>> > > * Fixed grammar
>> > > * Magic numbers for NVS offsets are replaced by defines
>> > > * Check for validity of mac address NVS data is moved into function
>> > > * Changed order of patches as Pavel requested
>> > >
>> > > Pali RohÃr (6):
>> > > wl1251: Update wl->nvs_len after wl->nvs is valid
>> > > wl1251: Generate random MAC address only if driver does not have
>> > > valid
>> > > wl1251: Parse and use MAC address from supplied NVS data
>> > > wl1251: Set generated MAC address back to NVS data
>> > > firmware: Add request_firmware_prefer_user() function
>> > > wl1251: Use request_firmware_prefer_user() for loading NVS
>> > > calibration data
>> > >
>> > > drivers/base/firmware_class.c | 45 +++++++++++++-
>> > > drivers/net/wireless/ti/wl1251/Kconfig | 1 +
>> > > drivers/net/wireless/ti/wl1251/main.c | 104 ++++++++++++++++++++++++++------
>> > > include/linux/firmware.h | 9 +++
>> > > 4 files changed, 138 insertions(+), 21 deletions(-)
>> >
>> > Hi! Are there any comments for first 4 patches? If not, could they be
>> > accepted and merged?
>>
>> Since the first 4 patches do not touch the firmware API they seem fine to me so
>> long as the maintainer accepts them. Maybe resend and clarify you have dropped
>> the other ones and amend with the new tags.
>
> According to get_maintainer.pl, Kalle Valo is maintainer.
>
> Kalle Valo, if you do not have any other comments, can you accept first
> 4 patches? Or do you really need to resent first 4 patches again?

The first 4 patches are now in my queue, I should get to them in the
next few days.

--
Kalle Valo