Re: [PATCH v2 1/2] mfd: arizona: Update reset pin to use GPIOD

[Charles Keepax]

On Mon, Feb 19, 2018 at 03:36:29PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 19, 2018 at 3:30 PM, Charles Keepax
> <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > Now GPIOD has support for both pdata systems and for non-standard DT
> > bindings the Arizona reset GPIO can be converted to use it.
> 
> >  static inline void arizona_enable_reset(struct arizona *arizona)
> >  {
> > -       if (arizona->pdata.reset)
> > -               gpio_set_value_cansleep(arizona->pdata.reset, 0);
> > +       gpiod_set_value_cansleep(arizona->pdata.reset, 0);
> >  }
> 
> Did you try that code when !GPIOLIB ?
> 
> Or driver depends on it?
> 

Hmm... yeah ok maybe I need to leave that if (reset) in, didn't
realise all those stubs straight up call WARNs. Although seems a bit
of a shame as gpiod_set_value_cansleep will do the NULL check as well.

Looks like attempt 3 it is :-)

Thanks,
Charles