Re: [PATCH] sparc: Use generic pci_mmap_resource_range()

From: David Miller
Date: Mon Feb 19 2018 - 09:49:59 EST


From: David Woodhouse <dwmw@xxxxxxxxxxxx>
Date: Mon, 19 Feb 2018 13:04:12 +0000

> Commit f719582435 ("PCI: Add pci_mmap_resource_range() and use it for
> ARM64") added this generic function with the intent of using it
> everywhere and ultimately killing the old arch-specific implementations.
>
> Let's get on with that eradication...
>
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>

David, the generic code is definitely doing different things.

For one, the sparc specific code allows mmap'ing any address range
within a PCI bus device. The generic code does not allow that.

I know this was used by the X server and that's why the logic is
there.

So we can't just use the generic code without breaking things, sorry.