Re: [PATCH 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout' property

From: Rob Herring
Date: Mon Feb 19 2018 - 10:59:50 EST


On Thu, Feb 15, 2018 at 12:49:25PM -0800, Moritz Fischer wrote:
> From: Moritz Fischer <mdf@xxxxxxxxxx>
>
> Add 'timeout' property to support boards where the 3s timeout that the
> current driver defaults to is too short.
>
> Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt b/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt
> index e62d53d844cc..c2459c7d45d5 100644
> --- a/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt
> +++ b/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt
> @@ -27,6 +27,8 @@ Optional properties:
> it to an output when the power-off handler is called. If this optional
> property is not specified, the GPIO is initialized as an output in its
> inactive state.
> +- timeout: Time to wait before asserting a WARN_ON(1). If nothing is
> + specified, 3000 ms is used.

Needs unit suffix as defined in property-units.txt.

>
> Examples:
>
> @@ -34,3 +36,9 @@ gpio-poweroff {
> compatible = "gpio-poweroff";
> gpios = <&gpio 4 0>;
> };
> +
> +gpio-poweroff {
> + compatible = "gpio-poweroff";
> + gpios = <&gpio 4 0>;
> + timeout = <3000>;

Just add to the existing example.

> +};
> --
> 2.16.1
>