Re: [PATCH 1/2] ASoC: topology: Rename clock_gated to clock_cont in snd_soc_tplg_hw_config

[Kirill Marinushkin]

On 02/19/18 07:47, Takashi Sakamoto wrote:
> Hi,
>
> On Feb 19 2018 15:05, Kirill Marinushkin wrote:
>> In kernel `soc-dai.h`, DAI clock gating is defined as following:
>>
>> ~~~~
>> \#define SND_SOC_DAIFMT_CONTÂÂÂÂÂÂÂ (1 << 4) /* continuous clock */
>> \#define SND_SOC_DAIFMT_GATEDÂÂÂÂÂÂÂ (0 << 4) /* clock is gated */
>> ~~~~
>>
>> Therefore, the corresponding field of struct snd_soc_tplg_hw_config should
>> be inverted compared to the current logic:
>>
>> clock_count = 1 => SND_SOC_DAIFMT_CONT
>> clock_count = 0 => SND_SOC_DAIFMT_GATED
>>
>> Signed-off-by: Kirill Marinushkin <k.marinushkin@xxxxxxxxx>
>> Cc: Jaroslav Kysela <perex@xxxxxxxx>
>> Cc: Takashi Iwai <tiwai@xxxxxxxx>
>> Cc: alsa-devel@xxxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> ---
>> Â include/uapi/sound/asoc.h | 4 +++-
>> Â 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h
>> index 69c37ecbff7e..10188850dede 100644
>> --- a/include/uapi/sound/asoc.h
>> +++ b/include/uapi/sound/asoc.h
>> @@ -312,7 +312,9 @@ struct snd_soc_tplg_hw_config {
>> ÂÂÂÂÂ __le32 size;ÂÂÂÂÂÂÂÂÂÂÂ /* in bytes of this structure */
>> ÂÂÂÂÂ __le32 id;ÂÂÂÂÂÂÂ /* unique ID - - used to match */
>> ÂÂÂÂÂ __le32 fmt;ÂÂÂÂÂÂÂ /* SND_SOC_DAI_FORMAT_ format value */
>> -ÂÂÂ __u8 clock_gated;ÂÂÂ /* 1 if clock can be gated to save power */
>> +ÂÂÂ __u8 clock_cont;ÂÂÂ /* 1 if clock is continuous, and can not be
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ * gated to save power
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ */
>> ÂÂÂÂÂ __u8 invert_bclk;ÂÂÂ /* 1 for inverted BCLK, 0 for normal */
>> ÂÂÂÂÂ __u8 invert_fsync;ÂÂÂ /* 1 for inverted frame clock, 0 for normal */
>> ÂÂÂÂÂ __u8 bclk_master;ÂÂÂ /* 1 for master of BCLK, 0 for slave */
>
> This structure was added at a commit 676c6b5208f7 ('ASoC: topology: ABI - Update physical DAI link configuration for version 5') in a development period for v4.10.
>
> This file is a part of UAPI, thus this structure has already been exposed to application developers. Any change can break userspace applications in a point of backward compatibility for this subsystem.
>
> It's better for you to investigate another solution for your two patches[1][2].
>
>
> [1] [alsa-devel] [PATCH 1/2] ASoC: topology: Rename clock_gated to clock_cont in snd_soc_tplg_hw_config
> http://mailman.alsa-project.org/pipermail/alsa-devel/2018-February/132258.html
> [2] [alsa-devel] [PATCH 2/2] ASoC: topology: Add missing clock gating parameter when parsing hw_configs
> http://mailman.alsa-project.org/pipermail/alsa-devel/2018-February/132259.html
>
>
> Regards
>
> Takashi Sakamoto

Hello Takashi Sakamoto,

I will propose a backwards-compatible solution as a PATCH v2.

Best Regards,
Kirill