Re: Build regressions/improvements in v4.16-rc2 (infiniband/hw/bnxt_re)

[Randy Dunlap]

On 02/19/18 05:57, Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.16-rc2[1] compared to v4.15[2].

Hi,
Just FYI, this driver could use some 32-bit attention.

> *** WARNINGS ***
> 
> 1659 warning regressions:
bytes is larger than 1024 bytes [-Wframe-larger-than=]:  => 78:1
>   + /home/kisskb/slave/src/drivers/infiniband/hw/bnxt_re/ib_verbs.c: warning: left shift count >= width of type [enabled by default]:  => 3550:2, 3552:4, 149:2

Above is due to:
#define BNXT_RE_MAX_MR_SIZE_HIGH	BIT(39)
#define BNXT_RE_MAX_MR_SIZE		BNXT_RE_MAX_MR_SIZE_HIGH
as 32-bit CPU cannot shift 39 bits left.

>   + /home/kisskb/slave/src/drivers/infiniband/hw/bnxt_re/qplib_fp.c: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]:  => 569:19
>   + /home/kisskb/slave/src/drivers/infiniband/hw/bnxt_re/qplib_fp.c: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]:  => 336:12, 333:23
>   + /home/kisskb/slave/src/drivers/infiniband/hw/bnxt_re/qplib_fp.c: warning: passing argument 1 of '__fswab64' makes integer from pointer without a cast [enabled by default]:  => 569:2
thanks
-- 
~Randy