Re: [PATCH 4/7] sched/fair: Avoid unnecessary balancing of asymmetric capacity groups

[Peter Zijlstra]

On Thu, Feb 15, 2018 at 04:20:51PM +0000, Morten Rasmussen wrote:
> +/*
> + * group_similar_cpu_capacity: Returns true if the minimum capacity of the
> + * compared groups differ by less than 12.5%.
> + */
> +static inline bool
> +group_similar_cpu_capacity(struct sched_group *sg, struct sched_group *ref)
> +{
> +	long diff = sg->sgc->min_capacity - ref->sgc->min_capacity;
> +	long max = max(sg->sgc->min_capacity, ref->sgc->min_capacity);
> +
> +	return abs(diff) < max >> 3;
> +}

This seems a fairly random and dodgy heuristic.