Re: [PATCH 5/6] Pmalloc: self-test
From: Igor Stoppa
Date: Tue Feb 20 2018 - 11:40:38 EST
On 13/02/18 01:43, Kees Cook wrote:
> On Mon, Feb 12, 2018 at 8:53 AM, Igor Stoppa <igor.stoppa@xxxxxxxxxx> wrote:
[...]
>> +obj-$(CONFIG_PROTECTABLE_MEMORY_SELFTEST) += pmalloc-selftest.o
>
> Nit: self-test modules are traditionally named "test_$thing.o"
> (outside of the tools/ directory).
ok
[...]
> I wonder if lkdtm should grow a test too, to validate the RO-ness of
> the allocations at the right time in API usage?
sorry for being dense ... are you proposing that I do something to
lkdtm_rodata.c ? An example would probably help me understand.
--
igor