Re: [PATCHv2 1/8] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

From: James Hogan
Date: Tue Feb 20 2018 - 18:06:25 EST


On Sun, Dec 31, 2017 at 02:28:24AM +0800, Jiaxun Yang wrote:
> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> index ab4d6cc57384..ba0474bb4a3d 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> @@ -1,3 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0
> +

No other cases I've seen bother with the blank line. Please remove
throughout the series.

> /*
> * the ACC Virtual Support Module of AMD CS5536
> *
> @@ -7,10 +9,6 @@
> * Copyright (C) 2009 Lemote, Inc.
> * Author: Wu Zhangjin, wuzhangjin@xxxxxxxxx
> *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of the GNU General Public License as published by the
> - * Free Software Foundation; either version 2 of the License, or (at your
> - * option) any later version.

or any later version implies it should be "GPL-2.0+"

Same throughout. Please check carefully you aren't changing the stated
license on any files.

Cheers
James

Attachment: signature.asc
Description: Digital signature