Re: [PATCH 2/2] proc: use set_puts() at /proc/*/wchan

From: Andrew Morton
Date: Tue Feb 20 2018 - 19:02:20 EST


On Sat, 17 Feb 2018 16:06:42 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Sat, Feb 17, 2018 at 9:20 AM, Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
> > Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
>
>
> > - seq_printf(m, "%s", symname);
> > + seq_puts(m, symname);
>
> While this might have no security concerns, the pattern might be
> brainlessly used by some janitors and there would have security
> implications.

And I'd like to see a changelog, please. One which explains why
`symname' cannot have a %s (etc) in it, and never will.