Re: [PATCH] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias
From: Geert Uytterhoeven
Date: Wed Feb 21 2018 - 04:35:04 EST
Hi Jaehoon,
On Wed, Feb 21, 2018 at 6:39 AM, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote:
> On 02/20/2018 07:50 PM, Geert Uytterhoeven wrote:
>> On Tue, Feb 20, 2018 at 10:03 AM, Geert Uytterhoeven
>> <geert+renesas@xxxxxxxxx> wrote:
>>> The hs_timing_cfg[] array is indexed using a value derived from the
>>> "mshcN" alias in DT, which may lead to an out-of-bounds access.
>>>
>>> Fix this by adding a range check.
>>>
>>> Fixes: 7d92895208a008a2 ("mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias")
>>
>> Oops
>>
>> Fixes: 361c7fe9b02eee7e ("mmc: dw_mmc-k3: add sd support for hi3660")
>
> Could you resend the patch with changing commit-msg?
> Then i will pick yours.
Sure. Will send a v2 soon.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds