Re: [PATCH] mm/page_poison: Make early_page_poison_param __init

From: Michal Hocko
Date: Wed Feb 21 2018 - 05:16:34 EST


On Wed 17-01-18 11:47:57, Dou Liyang wrote:
> The early_param() is only called during kernel initialization, So Linux
> marks the function of it with __init macro to save memory.
>
> But it forgot to mark the early_page_poison_param(). So, Make it __init
> as well.
>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Philippe Ombredanne <pombredanne@xxxxxxxx>
> Cc: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx
> Signed-off-by: Dou Liyang <douly.fnst@xxxxxxxxxxxxxx>

Acked-by: Michal Hocko <mhocko@xxxxxxxx>

> ---
> mm/page_poison.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_poison.c b/mm/page_poison.c
> index e83fd44867de..aa2b3d34e8ea 100644
> --- a/mm/page_poison.c
> +++ b/mm/page_poison.c
> @@ -9,7 +9,7 @@
>
> static bool want_page_poisoning __read_mostly;
>
> -static int early_page_poison_param(char *buf)
> +static int __init early_page_poison_param(char *buf)
> {
> if (!buf)
> return -EINVAL;
> --
> 2.14.3
>
>
>

--
Michal Hocko
SUSE Labs