Re: [PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

From: Dan Carpenter
Date: Wed Feb 21 2018 - 05:46:24 EST


On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
> Changed a variable name from camel to snake case to fix a coding style
> issue.
>
> Signed-off-by: Quytelda Kahja <quytelda@xxxxxxxxx>
> ---
> drivers/staging/gdm724x/hci_packet.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h
> index 22ce8b9477b6..f8837c7103ac 100644
> --- a/drivers/staging/gdm724x/hci_packet.h
> +++ b/drivers/staging/gdm724x/hci_packet.h
> @@ -50,7 +50,7 @@ struct tlv {
> struct sdu_header {
> __dev16 cmd_evt;
> __dev16 len;
> - __dev32 dftEpsId;
> + __dev32 dft_eps_ID;

I bet this is a part of the user space ABI or there is a specific reason
for the name to match the spec or something so it can't be changed...

regards,
dan carpenter