Re: [PATCH 11/23] kconfig: add 'shell-stdout' function
From: Linus Torvalds
Date: Wed Feb 21 2018 - 12:02:08 EST
On Tue, Feb 20, 2018 at 8:59 PM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> IMO, I prefer to use different names for different purpose.
> So, 'stdout' and 'success' look good to me.
>
> BTW, I noticed just one built-in function is enough
> because 'success' can be derived from 'stdout'.
>
> So, my plan is, implement $(shell ...) as a built-in function.
> This returns the stdout from the command.
>
> Then, implement 'success' as a textual shorthand
> by using macro, like this:
>
> macro success $(shell ($(1) && echo y) || echo n)
I like it. This is nice and clean, and seems to be very generic. I see
no issues with this approach.
Linus