Re: [PATCH 5/6] mm, hugetlb: further simplify hugetlb allocation API

From: Mike Kravetz
Date: Wed Feb 21 2018 - 13:00:01 EST


On 02/21/2018 02:01 AM, Michal Hocko wrote:
> On Wed 21-02-18 10:55:26, Michal Hocko wrote:
> Hmm, I guess I can see it. Does the following help?
> ---
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 7c204e3d132b..a963f2034dfc 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1583,7 +1583,7 @@ static struct page *alloc_surplus_huge_page(struct hstate *h, gfp_t gfp_mask,
> page = NULL;
> } else {
> h->surplus_huge_pages++;
> - h->nr_huge_pages_node[page_to_nid(page)]++;
> + h->surplus_huge_pages_node[page_to_nid(page)]++;
> }
>
> out_unlock:

I thought we had this corrected in a previous version of the patch.
My apologies for not looking more closely at this version.

FWIW,
Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
--
Mike Kravetz