Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node
From: Simon Horman
Date: Wed Feb 21 2018 - 13:23:50 EST
On Wed, Feb 21, 2018 at 08:53:53PM +0300, Sergei Shtylyov wrote:
> On 02/21/2018 08:38 PM, Sergei Shtylyov wrote:
...
> >>>>>> + clocks = <&cpg CPG_MOD 812>;
> >>>>>> + power-domains = <&sysc 32>;
> >>>>>> + resets = <&cpg 812>;
> >>>>>> + phy-mode = "rgmii-txid";
> >>>>>
> >>>>> Why not just "rgmii"? TX delay is a board specific detail, no?
> >>>>>
> >>>> I admit I took this one straight from r8a7796 dtsi.
> >>>> Would you like to me resend and change this?
> >>>
> >>> Yes, unless Simon would fix it while merging...
> >>
> >> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> >
> > Yes.
>
> Apparently that means that this prop should be overridden in the board file
> (which may not be an easy task given the board is Salvator-XS again).
>
> [...]
Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
I feel that I'm missing an important point here.