Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

[Andy Shevchenko]

On Wed, Feb 21, 2018 at 2:47 PM, Rolf Evers-Fischer
<embedded24@xxxxxxxxxxxxxxxx> wrote:

> This commit decreases the number of jump labels and ensures
> that the next commit doesn't increase the number of occurrences
> of 'kfree(func_name)'.

> Change-Id: I0d1b6fd652395b85f82b11c43bf9b7db512854d1

First of all, this shouldn't be here.

> Signed-off-by: Rolf Evers-Fischer <rolf.evers.fischer@xxxxxxxxx>
> Signed-off-by: Rolf Evers-Fischer <embedded24@xxxxxxxxxxxxxxxx>

Looks like bipolar disorder?

To the topic.
This is a slow path and your change makes code slightly less readable
b/c of patterns used in the kernel.

-- 
With Best Regards,
Andy Shevchenko