Re: [PATCH 08/20] lightnvm: complete geo structure with maxoc*

[Javier Gonzalez]

> On 22 Feb 2018, at 08.45, Matias BjÃrling <mb@xxxxxxxxxxx> wrote:
> 
> On 02/21/2018 10:26 AM, Javier GonzÃlez wrote:
>> Complete the generic geometry structure with the maxoc and maxocpu
>> felds, present in the 2.0 spec.
>> Signed-off-by: Javier GonzÃlez <javier@xxxxxxxxxxxx>
>> ---
>>  drivers/nvme/host/lightnvm.c | 4 ++++
>>  include/linux/lightnvm.h     | 2 ++
>>  2 files changed, 6 insertions(+)
>> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
>> index cca32da05316..9c1f8225c4e1 100644
>> --- a/drivers/nvme/host/lightnvm.c
>> +++ b/drivers/nvme/host/lightnvm.c
>> @@ -318,6 +318,8 @@ static int nvme_nvm_setup_12(struct nvme_nvm_id12 *id,
>>  	dev_geo->c.ws_min = sec_per_pg;
>>  	dev_geo->c.ws_opt = sec_per_pg;
>>  	dev_geo->c.mw_cunits = 8;		/* default to MLC safe values */
>> +	dev_geo->c.maxoc = dev_geo->all_luns;	/* default to 1 chunk per LUN */
>> +	dev_geo->c.maxocpu = 1;			/* default to 1 chunk per LUN */
> 
> One can't assume that it is 1 open chunk per lun. If you need this for specific hardware, make a quirk for it.
> 

Which default you want for 1.2 if not specified then? I use 1 because it
has been the implicit default until now.

Javier

Attachment: signature.asc
Description: Message signed with OpenPGP