Re: [PATCH v5 6/8] i2c: demux: Use changeset helpers for clarity

From: Laurent Pinchart
Date: Thu Feb 22 2018 - 05:18:56 EST


Hi Geert,

On Thursday, 22 February 2018 11:26:44 EET Geert Uytterhoeven wrote:
> On Thu, Feb 22, 2018 at 1:05 AM, Laurent Pinchart wrote:
> > From: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx>
> >
> > The changeset helpers are easier to use, use them instead of
> > using the static property.
> >
> > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx>
> > Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> > ["okay" -> "ok"]
>
> Why? ePAPR says "okay", "disabled", "fail", or "fail-sss".
>
> Sorry for missing this in the previous round.

That was per Wolfram's request, and because the existing code uses "ok". I'm
personally fine with any.

--
Regards,

Laurent Pinchart