Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

From: Herbert Xu
Date: Thu Feb 22 2018 - 06:48:03 EST


On Tue, Feb 20, 2018 at 11:32:25AM +0000, Horia GeantÄ wrote:
>
> If final/finup is optional, how is the final hash supposed to be retrieved?

Sometimes the computation ends with a partial hash, that's what
export is for. Also it is completely legal to abandon the hash
state entirely.

> According to documentation, these are the accepted flows (with the option to
> export/import a partial hash b/w update and final/finup):
>
> .init() -> .update() -> .final()
> ^ | |
> '----' '---> HASH
>
> .init() -> .update() -> .finup()
> ^ | |
> '----' '---> HASH
>
> .digest()
> |
> '---------------> HASH

The documentation is simply incomplete in this regard.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt