Re: [PATCH v5 0/7] Topstar U931/RVP7 ACPI LED Workaround

[Andy Shevchenko]

On Wed, Feb 21, 2018 at 6:59 PM, Guillaume DouÃzan-Grard
<gdouezangrard@xxxxxxxxx> wrote:
> Hi Andy,
>
> Thank you for your review. Changes since the previous submission are
> highlighted below.
>
> On Topstar U931/RVP7 Notebooks, an issue prevents the WLAN toggle key
> from being properly managed by the Embedded Controller and successfully
> disconnect the adapter. A specific ACPI method allows to toggle the WLAN
> LED state regardless.
>
> Based on a DMI check, the LED is registered within the corresponding
> subsystem, making possible to use a software-based trigger (rfkill for
> instance, to synchronize the LED with the network interface state).
>
> Thank you for your time,

All pushed to my review and testing queue, thanks!

>
> --
> Guillaume DouÃzan-Grard
>
>
> Changes since v4:
>
> * move module description comment change from patch 5 to 4,
> * fix SDPX identifiers mismatch.
>
>
> Changes since v3:
>
> * fix revert commit message format and wrapping,
> * update module description while actually doing the changes,
> * switch to SDPX identifiers.
>
>
> Changes since v2:
>
> * revert an older conversion from a generic module to an acpi driver
> module instead of undoing it manually,
> * separate commits for the renaming and the spliting phases,
> * DMI-based check instead of a module parameter,
> * copyright and minor fixes put at the end.
>
>
> Changes since v1:
>
> * leave devices names unchanged for ABI compatibility,
> * fix label names,
> * separate module authors definition,
> * add commit description to Patch 3.
>
>
> Guillaume DouÃzan-Grard (7):
>   platform/x86: topstar-laptop: revert "convert to module_acpi_driver()"
>   platform/x86: topstar-laptop: use consistent naming scheme
>   platform/x86: topstar-laptop: split ACPI events and input handling
>   platform/x86: topstar-laptop: add platform device
>   platform/x86: topstar-laptop: add Topstar U931/RVP7 WLAN LED
>     workaround
>   platform/x86: topstar-laptop: update copyright and fix some comments
>   platform/x86: topstar-laptop: replace licence text with SPDX tag
>
>  drivers/platform/x86/Kconfig          |   2 +
>  drivers/platform/x86/topstar-laptop.c | 363 +++++++++++++++++++++++++++-------
>  2 files changed, 291 insertions(+), 74 deletions(-)
>
> --
> 2.16.1
>



-- 
With Best Regards,
Andy Shevchenko