Re: [PATCH 1/6] arm64: dts: renesas: r8a77965: Add "reg" properties

[Geert Uytterhoeven]

Hi Jacopo,

On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote:
> Add "reg" properties to place-holder nodes with unit address defined for
> R-Car M3-N SoC.
>
> This silences the following DTC compiler warning:
> Warning (unit_address_vs_reg): Node /soc/... has a unit name,
> but no reg property
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>

A few minor nits below...

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> @@ -520,130 +521,163 @@
>                 };
>
>                 avb: ethernet@e6800000 {
> +                       reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>;

The first reg part would be sufficient for a placeholder.
I think even setting the size to zero would work...

>                 du: display@feb00000 {
> +                       reg = <0 0xfeb00000 0 0x70000>,

Unlike M3-W, the M3-N DU has a third channel, so the size is too small.

> +                             <0 0xfeb90000 0 0x14>;
>                         /* placeholder */

> @@ -703,38 +745,47 @@
>                 };
>
>                 usb2_phy1: usb-phy@ee0a0200 {
> +                       reg = <0 0xee0a0200 0 0x700>;
>                         /* placeholder */
>                 };

To be moved up, next to the other usb2 devices?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds