Re: [PATCH] staging: auxdisplay: add missing MODULE_LICENSE()

[Miguel Ojeda]

Hi Shannon,

On Wed, Jan 31, 2018 at 10:31 AM, Shannon Booth
<shannon.ml.booth@xxxxxxxxx> wrote:
> This patch fixes the compilation warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/auxdisplay/img-ascii-lcd.o
>
> Signed-off-by: Shannon Booth <shannon.ml.booth@xxxxxxxxx>
> ---
>  drivers/auxdisplay/img-ascii-lcd.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
> index db040b3..9222c88 100644
> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -441,3 +441,5 @@ static struct platform_driver img_ascii_lcd_driver = {
>         .remove = img_ascii_lcd_remove,
>  };
>  module_platform_driver(img_ascii_lcd_driver);
> +
> +MODULE_LICENSE("GPL v2");

This was already done by 09c479f7f1fbfaf848e5813996793966cd50be81
("auxdisplay: img-ascii-lcd: add missing
MODULE_DESCRIPTION/AUTHOR/LICENSE") back in early January.

In any case, it should have been "GPL" (i.e. version 2 or later), not
"GPL v2", according to the header in img-ascii-lcd.c, see:

  https://elixir.bootlin.com/linux/v4.16-rc2/source/include/linux/module.h#L171

But thank you for the patch! :-)

Cheers,
Miguel

> --
> 2.7.4
>