Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

[Simon Horman]

On Fri, Feb 23, 2018 at 08:06:11AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Feb 22, 2018 at 4:54 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote:
> >> On 02/21/2018 09:23 PM, Simon Horman wrote:
> >>
> >> > ...
> >> >
> >> >>>>>>>> +                    clocks = <&cpg CPG_MOD 812>;
> >> >>>>>>>> +                    power-domains = <&sysc 32>;
> >> >>>>>>>> +                    resets = <&cpg 812>;
> >> >>>>>>>> +                    phy-mode = "rgmii-txid";
> >> >>>>>>>
> >> >>>>>>>    Why not just "rgmii"? TX delay is a board specific detail, no?
> >> >>>>>>>
> >> >>>>>> I admit I took this one straight from r8a7796 dtsi.
> >> >>>>>> Would you like to me resend and change this?
> >> >>>>>
> >> >>>>>    Yes, unless Simon would fix it while merging...
> >> >>>>
> >> >>>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> >> >>>
> >> >>>    Yes.
> >> >>
> >> >>    Apparently that means that this prop should be overridden in the board file
> >> >> (which may not be an easy task given the board is Salvator-XS again).
> >> >>
> >> >> [...]
> >> >
> >> > Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts?
> >>
> >>    In salvator-common.dtsi most probably -- it has the PHY data for Ether AVB.
> >>
> >> > I feel that I'm missing an important point here.
> >>
> >>    Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was
> >>    unjustified in my current understanding). Thus such board override
> >>    wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi
> >>    in htis series, so I'm now thinking a respin of this series is needed
> >>    anyway... sorry for being unclear. :-)
> >
> > While I've applied other patches in this series I have
> > not applied this one - mainly to allow this discussion to conclude.
> >
> > Is an appropriate solution to do the following?
> >
> > 1) Atomically update
> >    a) r8a779{5|6}.dtsi to use "rgmii" and
> >    b) salvator-common.dtsi to use "rgmii-txid"
> > 2) Update this patch to use "rgmii"
> 
> No need for atomics.
> It can all be done by patches touching single files only:
>   1) Add "rgmii-txid" to board .dts(i) files,
>   2) Change s/rgmii-txid/rgmii/ in SoC .dtsi files.

Sounds good.

Jacopo would you care to:

a) Implement the above rgmii-txid / rgmii update.
b) Rebase this patch on top of that update and [PATCH v2 0/7] R-Car M3-N
   DTS fixes