Re: [PATCH bpf-next] bpf: NULL pointer check is not needed in BPF_CGROUP_RUN_PROG_INET_SOCK

From: David Miller
Date: Fri Feb 23 2018 - 12:45:01 EST


From: Yafang Shao <laoar.shao@xxxxxxxxx>
Date: Fri, 23 Feb 2018 14:58:41 +0800

> sk is already allocated in inet_create/inet6_create, hence when
> BPF_CGROUP_RUN_PROG_INET_SOCK is executed sk will never be NULL.
>
> The logic is as bellow,
> sk = sk_alloc();
> if (!sk)
> goto out;
> BPF_CGROUP_RUN_PROG_INET_SOCK(sk);
>
> Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>