Re: [PATCH v3 0/2] add support for Socionext SynQuacer I2C controller

From: Andy Shevchenko
Date: Tue Feb 27 2018 - 10:59:29 EST


On Tue, Feb 27, 2018 at 1:01 PM, Ard Biesheuvel
<ard.biesheuvel@xxxxxxxxxx> wrote:
> Add a binding and a driver for the I2C IP found in the Socionext SynQuacer
> SoC, which is essentially a rebranded version of the Fujitsu F_I2C controller.
>

Thanks for an update!
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

P.S. clk_prepare_enable() may fail in ->probe() as well.

> v3:
> - incorporate more of Andy's review comments (#2), especially regarding the
> bus speed and clock source handling for ACPI
> - patch #1 unchanged.
>
> v2:
> - incorporate Andy's review comments (#2)
> - patch #1 unchanged.
>
> Ard Biesheuvel (2):
> dt-bindings: i2c: add binding for Socionext SynQuacer I2C
> i2c: add support for Socionext SynQuacer I2C controller
>
> Documentation/devicetree/bindings/i2c/i2c-synquacer.txt | 29 +
> drivers/i2c/busses/Kconfig | 10 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-synquacer.c | 787 ++++++++++++++++++++
> 4 files changed, 827 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-synquacer.txt
> create mode 100644 drivers/i2c/busses/i2c-synquacer.c
>
> --
> 2.11.0
>



--
With Best Regards,
Andy Shevchenko