Re: [PATCH v8 1/8] drm/bridge: analogix: Do not use device's drvdata
From: Heiko Stübner
Date: Thu Mar 01 2018 - 10:39:54 EST
Am Mittwoch, 10. Januar 2018, 17:23:41 CET schrieb Thierry Escande:
> From: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
>
> The driver that instantiates the bridge should own the drvdata, as all
> driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also
> owned by its driver struct. Moreover, storing two different pointer
> types in driver data depending on driver initialization status is barely
> a good practice and in fact has led to many bugs in this driver.
>
> Let's clean up this mess and change Analogix entry points to simply
> accept some opaque struct pointer, adjusting their users at the same
> time to avoid breaking the compilation.
>
> Signed-off-by: Tomasz Figa <tfiga@xxxxxxxxxxxx>
> Signed-off-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
> Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxxxxx>
> Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> Acked-by: Jingoo Han <jingoohan1@xxxxxxxxx>
> Acked-by: Archit Taneja <architt@xxxxxxxxxxxxxx>
applied to drm-misc-next as it had Reviews/Acks from drm-bridge people
Thanks
Heiko