Re: [PATCH 1/6] kbuild: remove remaining use of undefined YACC_PREFIX

From: Rob Herring
Date: Thu Mar 01 2018 - 10:39:14 EST


On Thu, Mar 1, 2018 at 8:01 AM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> 2018-03-01 22:39 GMT+09:00 Rob Herring <robh@xxxxxxxxxx>:
>> On Thu, Mar 1, 2018 at 5:35 AM, Masahiro Yamada
>> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>>> Hi Rob,
>>>
>>> 2018-03-01 13:20 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
>>>> 2018-03-01 8:32 GMT+09:00 Rob Herring <robh@xxxxxxxxxx>:
>>>>> Commit eea199b445f6 ("kbuild: remove unnecessary LEX_PREFIX and
>>>>> YACC_PREFIX") removed YACC_PREFIX definition, but left one use of it. There
>>>>> was not any build error since there is no user of "cmd_bison_h" currently.
>>>>> Remove the last remaining occurrence of YACC_PREFIX.
>>>>>
>>>>> Fixes: eea199b445f6 ("kbuild: remove unnecessary LEX_PREFIX and YACC_PREFIX")
>>>>> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>>>> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>>>>
>>>> You can replace CC with my
>>>>
>>>> Acked-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>>
>>>
>>> I got a reason to send a fixes pull request this week.
>>>
>>> If you do not mind, may I include this one in
>>> my Kbuild fixes pull request?
>>
>> Yes, please do.
>>
>>>
>>> I do not see dependency between 1/6 and the rest of the series.
>>
>> Only that dtc won't build without it. :)
>>
>
> Sorry, I missed that.
> You are right.
>
> I see this series is already queued up in your tree.

It is not really queued up, I just pushed out a tree for 0-day
testing. And it turns out I need strrchr in several places.

> So, just keep it in your tree.

Okay.

Rob