Re: [PATCH 4.4 64/67] usb: uas: unconditionally bring back host after reset

From: Ben Hutchings
Date: Fri Mar 02 2018 - 19:19:36 EST


On Fri, 2018-02-02 at 17:58 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.
>
> ------------------
>
> From: Oliver Neukum <oneukum@xxxxxxxx>
>
> commit cbeef22fd611c4f47c494b821b2b105b8af970bb upstream.
[...]
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -1052,20 +1052,19 @@ static int uas_post_reset(struct usb_int
> Â return 0;
> Â
>Â err = uas_configure_endpoints(devinfo);
> - if (err) {
> + if (err && err != ENODEV)
> Â shost_printk(KERN_ERR, shost,
> Â ÂÂÂÂÂ"%s: alloc streams error %d after reset",
> Â ÂÂÂÂÂ__func__, err);
[...]

This should be checking for -ENODEV, shouldn't it?

Ben.

--
Ben Hutchings
Software Developer, Codethink Ltd.