Re: [PATCH 4.4 64/67] usb: uas: unconditionally bring back host after reset

From: Hans de Goede
Date: Sat Mar 03 2018 - 04:14:54 EST

Hi,

On 03-03-18 01:19, Ben Hutchings wrote:
On Fri, 2018-02-02 at 17:58 +0100, Greg Kroah-Hartman wrote:
4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.

------------------

From: Oliver Neukum <oneukum@xxxxxxxx>

commit cbeef22fd611c4f47c494b821b2b105b8af970bb upstream.
[...]
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -1052,20 +1052,19 @@ static int uas_post_reset(struct usb_int
 return 0;
 err = uas_configure_endpoints(devinfo);
- if (err) {
+ if (err && err != ENODEV)
 shost_printk(KERN_ERR, shost,
 ÂÂÂÂÂ"%s: alloc streams error %d after reset",
 ÂÂÂÂÂ__func__, err);
[...]

This should be checking for -ENODEV, shouldn't it?

Yes you're right, the check should be != -ENODEV.

Oliver can you do a follow-up patch fixing this please?

Regards,

Hans