Re: [PATCH 2/6] Staging: iio: adis16209: Change the definition name

From: Jonathan Cameron
Date: Sat Mar 03 2018 - 10:40:41 EST


On Fri, 2 Mar 2018 18:53:41 +0530
Shreeya Patel <shreeya.patel23498@xxxxxxxxx> wrote:

> The change in the definition name makes it then obvious
> what the units are throughout the driver and there will
> be no need of the comment.
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@xxxxxxxxx>
Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan
> ---
> drivers/staging/iio/accel/adis16209.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
> index 58f604d..830c278 100644
> --- a/drivers/staging/iio/accel/adis16209.c
> +++ b/drivers/staging/iio/accel/adis16209.c
> @@ -20,7 +20,7 @@
> #include <linux/iio/buffer.h>
> #include <linux/iio/imu/adis.h>
>
> -#define ADIS16209_STARTUP_DELAY 220 /* ms */
> +#define ADIS16209_STARTUP_DELAY_MS 220
>
> /* Flash memory write count */
> #define ADIS16209_FLASH_CNT 0x00
> @@ -303,7 +303,7 @@ static const struct adis_data adis16209_data = {
>
> .self_test_mask = ADIS16209_MSC_CTRL_SELF_TEST_EN,
> .self_test_no_autoclear = true,
> - .startup_delay = ADIS16209_STARTUP_DELAY,
> + .startup_delay = ADIS16209_STARTUP_DELAY_MS,
>
> .status_error_msgs = adis16209_status_error_msgs,
> .status_error_mask = BIT(ADIS16209_DIAG_STAT_SELFTEST_FAIL_BIT) |